Add opensearch promotion workflow and jenkins libs for tar #1354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1354 +/- ##
============================================
- Coverage 94.02% 93.85% -0.17%
Complexity 11 11
============================================
Files 136 136
Lines 3011 3011
Branches 8 8
============================================
- Hits 2831 2826 -5
- Misses 172 177 +5
Partials 8 8
Continue to review full report at Codecov.
|
Signed-off-by: Peter Zhu <[email protected]>
gaiksaya
requested changes
Dec 16, 2021
There was a problem hiding this comment.
Overall this looks great. Will save us manual work especially after signing part (cc: @abhinavGupta16)
Thanks!
Signed-off-by: Peter Zhu <[email protected]>
|
Add a test for the new function in vars and this looks good to me. |
peternied
reviewed
Dec 16, 2021
gaiksaya
approved these changes
Dec 16, 2021
|
@dblock @peternied @gaiksaya here is the improvement issue for this task: #1355 Please review again so we can unblock this and merge. Thanks. |
peternied
approved these changes
Dec 16, 2021
dblock
approved these changes
Dec 16, 2021
This was referenced Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Zhu [email protected]
Description
Add opensearch promotion workflow and jenkins libs for tar
Issues Resolved
#1332
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.